[clang] Redesign handling of anyAppleOS availability attribute (PR #190817)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/AttrImpl.cpp.o</summary>

```
FAILED: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/AttrImpl.cpp.o
sccache /opt/llvm/bin/clang++ -DCLANG_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/lib/AST -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/AST -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/AttrImpl.cpp.o -MF tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/AttrImpl.cpp.o.d -o tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/AttrImpl.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/AST/AttrImpl.cpp
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/AST/AttrImpl.cpp:13:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include/clang/AST/ASTContext.h:18:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include/clang/AST/CanonicalType.h:17:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include/clang/AST/Type.h:20:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include/clang/AST/Decl.h:16:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include/clang/AST/APNumericStorage.h:12:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/ADT/APFloat.h:18:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/ADT/APInt.h:19:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/MathExtras.h:16:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/ADT/STLForwardCompat.h:21:
In file included from /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/functional:49:
In file included from /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_function.h:60:
In file included from /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/move.h:37:
/usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/type_traits:3361:60: error: incomplete type 'clang::OMPTraitInfo' used in type trait expression
3361 |   inline constexpr bool is_base_of_v = __is_base_of(_Base, _Derived);
|                                                            ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/AST/AttrImpl.cpp:326:32: note: in instantiation of variable template specialization 'std::is_base_of_v<clang::Attr, clang::OMPTraitInfo>' requested here
326 | typename std::enable_if_t<std::is_base_of_v<Attr, T>, bool>
|                                ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/include/clang/AST/AttrImpl.inc:32192:8: note: while substituting deduced template arguments into function template 'equalAttrArgs' [with T = OMPTraitInfo]
32192 |   if (!equalAttrArgs(getTraitInfos(), Other.getTraitInfos(), Context))
|        ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include/clang/AST/ASTContext.h:130:7: note: forward declaration of 'clang::OMPTraitInfo'
130 | class OMPTraitInfo;
|       ^
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/190817