[clang] Diagnose potential size confusion with VLA params [contd.] (PR #181550)

[Aryan Kadole via cfe-commits]

================
@@ -1114,7 +1114,8 @@ def VexingParse : DiagGroup<"vexing-parse">;
 def VLAUseStaticAssert : DiagGroup<"vla-extension-static-assert">;
 def VLACxxExtension : DiagGroup<"vla-cxx-extension", [VLAUseStaticAssert]>;
 def VLAExtension : DiagGroup<"vla-extension", [VLACxxExtension]>;
-def VLA : DiagGroup<"vla", [VLAExtension]>;
+def VLASizeConfusion : DiagGroup<"vla-potential-size-confusion">;
----------------
ak1932 wrote:

> I think the flag should be something like -Warray-parameter-size-confusion

Yes, I agree, `-Warray-parameter-size-confusion` would be a better fit. I will update the flag; are there any more changes @AaronBallman would like to suggest or we can move forward with the PR with this change? 😃

>  The connection to -fbounds-safety and -fexperimental-late-parse-attributes is something I see as much farther down the road

I see. We can look into it later then.

https://github.com/llvm/llvm-project/pull/181550