[clang] Diagnose potential size confusion with VLA params [contd.] (PR #181550)

[Aaron Ballman via cfe-commits]

================
@@ -1114,7 +1114,8 @@ def VexingParse : DiagGroup<"vexing-parse">;
 def VLAUseStaticAssert : DiagGroup<"vla-extension-static-assert">;
 def VLACxxExtension : DiagGroup<"vla-cxx-extension", [VLAUseStaticAssert]>;
 def VLAExtension : DiagGroup<"vla-extension", [VLACxxExtension]>;
-def VLA : DiagGroup<"vla", [VLAExtension]>;
+def VLASizeConfusion : DiagGroup<"vla-potential-size-confusion">;
----------------
AaronBallman wrote:

> @AaronBallman Would you have any concerns narrowing this PR to focus just on the array size issue, so we can move forward with it?

I think it's fine to focus on array size in function parameters at the moment, but I think there's two different (but related) diagnostics depending on whether `-fexperimental-late-parse-attributes` is enabled or not. Did my example above help clarify?

https://github.com/llvm/llvm-project/pull/181550