[clang] [CIR][WIP] Make BeginCatchOp target-independent (PR #190612)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 88444 tests passed
* 774 tests skipped
* 8 tests failed

## Failed Tests
(click on a test name to see its output)

### Clang
<details>
<summary>Clang.CIR/Transforms/eh-abi-lowering-itanium.cir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/eh-abi-lowering-itanium.cir -cir-eh-abi-lowering -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/eh-abi-lowering-itanium.cir.tmp.cir
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/eh-abi-lowering-itanium.cir -cir-eh-abi-lowering -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/eh-abi-lowering-itanium.cir.tmp.cir
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/eh-abi-lowering-itanium.cir:80:31: error: custom op 'cir.begin_catch' expected string or keyword containing one of the following enum values for attribute 'kind' [default, load_store, store, memcopy, reference]
# |   %ct, %exn = cir.begin_catch %eh_token.1 : !cir.eh_token -> (!cir.catch_token, !cir.ptr<!void>)
# |                               ^
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>Clang.CIR/Transforms/flatten-preserve-attrs.cir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-preserve-attrs.cir -cir-flatten-cfg -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/flatten-preserve-attrs.cir.tmp.cir
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-preserve-attrs.cir -cir-flatten-cfg -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/flatten-preserve-attrs.cir.tmp.cir
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-preserve-attrs.cir:15:48: error: custom op 'cir.begin_catch' expected string or keyword containing one of the following enum values for attribute 'kind' [default, load_store, store, memcopy, reference]
# |       %catch_token, %exn_ptr = cir.begin_catch %eh_token : !cir.eh_token -> (!cir.catch_token, !cir.ptr<!cir.void>)
# |                                                ^
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>Clang.CIR/Transforms/flatten-throwing-in-cleanup.cir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-throwing-in-cleanup.cir -cir-flatten-cfg -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/flatten-throwing-in-cleanup.cir.tmp.cir
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-throwing-in-cleanup.cir -cir-flatten-cfg -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/flatten-throwing-in-cleanup.cir.tmp.cir
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-throwing-in-cleanup.cir:110:40: error: custom op 'cir.begin_catch' expected string or keyword containing one of the following enum values for attribute 'kind' [default, load_store, store, memcopy, reference]
# |     %catch_token, %1 = cir.begin_catch %eh_token : !cir.eh_token -> (!cir.catch_token, !cir.ptr<!cir.void>)
# |                                        ^
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>Clang.CIR/Transforms/flatten-try-op.cir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-try-op.cir -cir-flatten-cfg -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/flatten-try-op.cir.tmp.cir
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-try-op.cir -cir-flatten-cfg -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/flatten-try-op.cir.tmp.cir
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-try-op.cir:46:48: error: custom op 'cir.begin_catch' expected string or keyword containing one of the following enum values for attribute 'kind' [default, load_store, store, memcopy, reference]
# |       %catch_token, %exn_ptr = cir.begin_catch %eh_token : !cir.eh_token -> (!cir.catch_token, !cir.ptr<!cir.void>)
# |                                                ^
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>Clang.CIR/Transforms/eh-abi-lowering-itanium.cir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/eh-abi-lowering-itanium.cir -cir-eh-abi-lowering -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/eh-abi-lowering-itanium.cir.tmp.cir
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/eh-abi-lowering-itanium.cir -cir-eh-abi-lowering -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/eh-abi-lowering-itanium.cir.tmp.cir
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/eh-abi-lowering-itanium.cir:80:31: error: custom op 'cir.begin_catch' expected string or keyword containing one of the following enum values for attribute 'kind' [default, load_store, store, memcopy, reference]
# |   %ct, %exn = cir.begin_catch %eh_token.1 : !cir.eh_token -> (!cir.catch_token, !cir.ptr<!void>)
# |                               ^
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>Clang.CIR/Transforms/flatten-preserve-attrs.cir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-preserve-attrs.cir -cir-flatten-cfg -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/flatten-preserve-attrs.cir.tmp.cir
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-preserve-attrs.cir -cir-flatten-cfg -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/flatten-preserve-attrs.cir.tmp.cir
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-preserve-attrs.cir:15:48: error: custom op 'cir.begin_catch' expected string or keyword containing one of the following enum values for attribute 'kind' [default, load_store, store, memcopy, reference]
# |       %catch_token, %exn_ptr = cir.begin_catch %eh_token : !cir.eh_token -> (!cir.catch_token, !cir.ptr<!cir.void>)
# |                                                ^
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>Clang.CIR/Transforms/flatten-throwing-in-cleanup.cir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-throwing-in-cleanup.cir -cir-flatten-cfg -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/flatten-throwing-in-cleanup.cir.tmp.cir
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-throwing-in-cleanup.cir -cir-flatten-cfg -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/flatten-throwing-in-cleanup.cir.tmp.cir
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-throwing-in-cleanup.cir:110:40: error: custom op 'cir.begin_catch' expected string or keyword containing one of the following enum values for attribute 'kind' [default, load_store, store, memcopy, reference]
# |     %catch_token, %1 = cir.begin_catch %eh_token : !cir.eh_token -> (!cir.catch_token, !cir.ptr<!cir.void>)
# |                                        ^
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>Clang.CIR/Transforms/flatten-try-op.cir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-try-op.cir -cir-flatten-cfg -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/flatten-try-op.cir.tmp.cir
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/cir-opt /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-try-op.cir -cir-flatten-cfg -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/CIR/Transforms/Output/flatten-try-op.cir.tmp.cir
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CIR/Transforms/flatten-try-op.cir:46:48: error: custom op 'cir.begin_catch' expected string or keyword containing one of the following enum values for attribute 'kind' [default, load_store, store, memcopy, reference]
# |       %catch_token, %exn_ptr = cir.begin_catch %eh_token : !cir.eh_token -> (!cir.catch_token, !cir.ptr<!cir.void>)
# |                                                ^
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/190612