[clang] [llvm] [Support][Modules] Removed prepareForGetLock and its usages. Ensured parent directory exists when creating lock file. (PR #189888)

Jan Svoboda via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 6 07:48:31 PDT 2026


================
@@ -106,18 +106,9 @@ class CrossProcessModuleCache : public ModuleCache {
   InMemoryModuleCache InMemory;
 
 public:
-  void prepareForGetLock(StringRef ModuleFilename) override {
-    // This is a compiler-internal input/output, let's bypass the sandbox.
-    auto BypassSandbox = llvm::sys::sandbox::scopedDisable();
-
-    // FIXME: Do this in LockFileManager and only if the directory doesn't
-    // exist.
-    StringRef Dir = llvm::sys::path::parent_path(ModuleFilename);
-    llvm::sys::fs::create_directories(Dir);
-  }
-
   std::unique_ptr<llvm::AdvisoryLock>
   getLock(StringRef ModuleFilename) override {
+    auto BypassSandbox = llvm::sys::sandbox::scopedDisable();
----------------
jansvoboda11 wrote:

Move this into the lock manager code please.

https://github.com/llvm/llvm-project/pull/189888


More information about the cfe-commits mailing list