[clang] [clang] Store size & mtime in in-memory module cache (PR #190207)

Cyndy Ishida via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 3 13:56:03 PDT 2026


================
@@ -1498,7 +1500,7 @@ static bool compileModuleImpl(CompilerInstance &ImportingInstance,
   Buffer = llvm::MemoryBuffer::getMemBufferCopy(ExtractedBuffer);
 
   ImportingInstance.getModuleCache().getInMemoryModuleCache().addBuiltPCM(
----------------
cyndyishida wrote:

Not strictly related to the PR, but what is the benefit of exposing the `InMemoryModuleCache` to clients like `CompilerInstance`, `ASTReader`, `ModuleManager`? It seems like it would be easier to reason only about the `ModuleCache` at this scope.  FWIW, I also kind of similiarly about the `CompilerInstance` should not be responsible for updating the ModuleTimestamp.


https://github.com/llvm/llvm-project/pull/190207


More information about the cfe-commits mailing list