[clang] Add spirv-val compilation step when targeting SPIR-V (PR #188150)

Justin Bogner via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 3 12:25:28 PDT 2026


================
@@ -574,18 +606,31 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args, StringRef BoundArch,
   return DAL;
 }
 
-bool HLSLToolChain::requiresValidation(DerivedArgList &Args) const {
-  if (!Args.hasArg(options::OPT_dxc_Fo))
+bool HLSLToolChain::requiresValidation(DerivedArgList &Args,
+                                       bool Diagnose) const {
----------------
bogner wrote:

I guess the addition of the `Diagnose` argument here fixes an existing bug where we double diagnose if dxv is missing?

https://github.com/llvm/llvm-project/pull/188150


More information about the cfe-commits mailing list