[clang] [llvm] [LLVM][Support] Enforce proper instantiations of `Registry<T>` (PR #185141)

[Tomohiro Kashiwada via cfe-commits]

kikairoya wrote:

After replacing all `LLVM_INSTANTIATE_REGISTRY` with `LLVM_DEFINE_REGISTRY`:

```
$ find . -name '*.o' -execdir nm -U -j '{}' + | grep 8RegistryI | sort | uniq -c | sort -r
      3 _ZNK4llvm8RegistryIN5clang15PluginASTActionEJEE8iteratoreqERKS4_
      3 _ZNK4llvm8RegistryIN5clang15PluginASTActionEJEE8iteratordeEv
      3 _ZNK4llvm20iterator_facade_baseINS_8RegistryIN5clang15PluginASTActionEJEE8iteratorESt20forward_iterator_tagKNS_19SimpleRegistryEntryIS3_JEEElPS9_RS9_EneERKS5_
      3 _ZNK4llvm14iterator_rangeINS_8RegistryIN5clang15PluginASTActionEJEE8iteratorEE5beginEv
      3 _ZNK4llvm14iterator_rangeINS_8RegistryIN5clang15PluginASTActionEJEE8iteratorEE3endEv
      3 _ZN4llvm8RegistryIN5clang15PluginASTActionEJEE8iteratorppEv
      3 _ZN4llvm8RegistryIN5clang15PluginASTActionEJEE8iteratorC2EPKNS3_4nodeE
      3 _ZN4llvm8RegistryIN5clang15PluginASTActionEJEE7entriesEv
      3 _ZN4llvm8RegistryIN5clang15PluginASTActionEJEE5beginEv
      3 _ZN4llvm8RegistryIN5clang15PluginASTActionEJEE3endEv
      3 _ZN4llvm14iterator_rangeINS_8RegistryIN5clang15PluginASTActionEJEE8iteratorEEC2ES5_S5_
      3 _ZN4llvm10make_rangeINS_8RegistryIN5clang15PluginASTActionEJEE8iteratorEEENS_14iterator_rangeIT_EES7_S7_
      2 _ZNK4llvm8RegistryIN5clang14ParsedAttrInfoEJEE8iteratoreqERKS4_
      2 _ZNK4llvm8RegistryIN5clang14ParsedAttrInfoEJEE8iteratordeEv
      2 _ZNK4llvm20iterator_facade_baseINS_8RegistryIN5clang4ssaf19SerializationFormatEJEE8iteratorESt20forward_iterator_tagKNS_19SimpleRegistryEntryIS4_JEEElPSA_RSA_EneERKS6_
      2 _ZNK4llvm20iterator_facade_baseINS_8RegistryIN5clang14ParsedAttrInfoEJEE8iteratorESt20forward_iterator_tagKNS_19SimpleRegistryEntryIS3_JEEElPS9_RS9_EneERKS5_
      2 _ZNK4llvm14iterator_rangeINS_8RegistryIN5clang4ssaf19SerializationFormatEJEE8iteratorEE5beginEv
      2 _ZNK4llvm14iterator_rangeINS_8RegistryIN5clang4ssaf19SerializationFormatEJEE8iteratorEE3endEv
      2 _ZNK4llvm14iterator_rangeINS_8RegistryIN5clang14ParsedAttrInfoEJEE8iteratorEE5beginEv
      2 _ZNK4llvm14iterator_rangeINS_8RegistryIN5clang14ParsedAttrInfoEJEE8iteratorEE3endEv
      2 _ZN4llvm8RegistryINS_17GCMetadataPrinterEJEE4nodeC2ERKNS_19SimpleRegistryEntryIS1_JEEE
      2 _ZN4llvm8RegistryIN5clang7tooling25CompilationDatabasePluginEJEE4nodeC2ERKNS_19SimpleRegistryEntryIS3_JEEE
      2 _ZN4llvm8RegistryIN5clang7tooling18ToolExecutorPluginEJEE4nodeC2ERKNS_19SimpleRegistryEntryIS3_JEEE
      2 _ZN4llvm8RegistryIN5clang14ParsedAttrInfoEJEE8iteratorppEv
      2 _ZN4llvm8RegistryIN5clang14ParsedAttrInfoEJEE8iteratorC2EPKNS3_4nodeE
      2 _ZN4llvm8RegistryIN5clang14ParsedAttrInfoEJEE7entriesEv
      2 _ZN4llvm8RegistryIN5clang14ParsedAttrInfoEJEE5beginEv
      2 _ZN4llvm8RegistryIN5clang14ParsedAttrInfoEJEE3endEv
      2 _ZN4llvm14iterator_rangeINS_8RegistryIN5clang14ParsedAttrInfoEJEE8iteratorEEC2ES5_S5_
      2 _ZN4llvm10make_rangeINS_8RegistryIN5clang14ParsedAttrInfoEJEE8iteratorEEENS_14iterator_rangeIT_EES7_S7_
      1 _ZZN4llvm6detail27getRegistryLinkListInstanceINS_8RegistryINS_17GCMetadataPrinterEJEEEEERNS0_23RegistryLinkListStorageIT_EEvE8Instance
      1 _ZZN4llvm6detail27getRegistryLinkListInstanceINS_8RegistryINS_10GCStrategyEJEEEEERNS0_23RegistryLinkListStorageIT_EEvE8Instance
      1 _ZZN4llvm6detail27getRegistryLinkListInstanceINS_8RegistryIN5clang7tooling25CompilationDatabasePluginEJEEEEERNS0_23RegistryLinkListStorageIT_EEvE8Instance
      1 _ZZN4llvm6detail27getRegistryLinkListInstanceINS_8RegistryIN5clang7tooling18ToolExecutorPluginEJEEEEERNS0_23RegistryLinkListStorageIT_EEvE8Instance
      1 _ZZN4llvm6detail27getRegistryLinkListInstanceINS_8RegistryIN5clang4ssaf22SummaryDataBuilderBaseEJEEEEERNS0_23RegistryLinkListStorageIT_EEvE8Instance
      1 _ZZN4llvm6detail27getRegistryLinkListInstanceINS_8RegistryIN5clang4ssaf19SerializationFormatEJEEEEERNS0_23RegistryLinkListStorageIT_EEvE8Instance
      1 _ZZN4llvm6detail27getRegistryLinkListInstanceINS_8RegistryIN5clang4ssaf18TUSummaryExtractorEJRNS4_16TUSummaryBuilderEEEEEERNS0_23RegistryLinkListStorageIT_EEvE8Instance
(snip)

```


https://github.com/llvm/llvm-project/pull/185141