[clang] [clang][ssaf] Add JSONFormat support for WPASuite (PR #187403)

[Balázs Benics via cfe-commits]

================
@@ -153,13 +151,14 @@ class SerializationFormat {
 
         static std::string NameStr =
             AnalysisResultT::analysisName().str().str();
-        static typename RegistryT::template Add<ConcreteEntry> Reg(NameStr, "");
+        static typename llvm::Registry<Entry>::template Add<ConcreteEntry> Reg(
----------------
steakhal wrote:

Please spell it out. `Reg` -> `Register`.
It confused me and I incidentally thought that I can remove this unused variable declaration.
I'd go as far as to even put a `[[maybe_unused]]` or maybe even better: leave a comment there that we need this side-effect!
A variable name `RegisterUsingCtorSideEffect` could be another option.

https://github.com/llvm/llvm-project/pull/187403