[clang] fixup! [clang][analyzer] Forward CTU-import failure conditions (PR #190145)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Arseniy Zaostrovnykh (necto)

<details>
<summary>Changes</summary>

Fix the Sphinx build failure introduced in #<!-- -->189064  by using a dedicated group for CTU remarks.

---
Full diff: https://github.com/llvm/llvm-project/pull/190145.diff


3 Files Affected:

- (modified) clang/include/clang/Basic/DiagnosticCrossTUKinds.td (+1-1) 
- (modified) clang/include/clang/Basic/DiagnosticGroups.td (+1) 
- (modified) clang/test/Analysis/ctu/diag/load-threshold.cpp (+1-1) 


``````````diff
diff --git a/clang/include/clang/Basic/DiagnosticCrossTUKinds.td b/clang/include/clang/Basic/DiagnosticCrossTUKinds.td
index 7785751651dfb..13498a7f16ac8 100644
--- a/clang/include/clang/Basic/DiagnosticCrossTUKinds.td
+++ b/clang/include/clang/Basic/DiagnosticCrossTUKinds.td
@@ -41,7 +41,7 @@ def err_ctu_import_failure: Error<
 
 def remark_ctu_import_threshold_reached: Remark<
   "reached a the CTU-import threshold before trying to import definition">,
-  InGroup<CrossTU>;
+  InGroup<CrossTURemarks>;
 
 def warn_ctu_incompat_lang : Warning<
   "imported AST from '%0' had been generated for a different language, "
diff --git a/clang/include/clang/Basic/DiagnosticGroups.td b/clang/include/clang/Basic/DiagnosticGroups.td
index 6e82203d858f5..dc7280c66ea79 100644
--- a/clang/include/clang/Basic/DiagnosticGroups.td
+++ b/clang/include/clang/Basic/DiagnosticGroups.td
@@ -1800,6 +1800,7 @@ def BoundsSafetyCountedByEltTyUnknownSize :
 
 // A group for cross translation unit static analysis related warnings.
 def CrossTU : DiagGroup<"ctu">;
+def CrossTURemarks : DiagGroup<"ctu-remarks">;
 
 def CTADMaybeUnsupported : DiagGroup<"ctad-maybe-unsupported">;
 
diff --git a/clang/test/Analysis/ctu/diag/load-threshold.cpp b/clang/test/Analysis/ctu/diag/load-threshold.cpp
index 4353dab60d0cd..222dac6b98b78 100644
--- a/clang/test/Analysis/ctu/diag/load-threshold.cpp
+++ b/clang/test/Analysis/ctu/diag/load-threshold.cpp
@@ -25,7 +25,7 @@
 // RUN:   -analyzer-config experimental-enable-naive-ctu-analysis=true \
 // RUN:   -analyzer-config ctu-dir=%t \
 // RUN:   -analyzer-config ctu-import-cpp-threshold=1 \
-// RUN:   -Rctu \
+// RUN:   -Rctu-remarks \
 // RUN:   -verify %s
 
 // foo is loaded successfully (first load, within threshold).

``````````

</details>


https://github.com/llvm/llvm-project/pull/190145