[clang] [clang][modules-driver] Avoid copy of -cc1 command & const correctness (NFC) (PR #190142)

[Naveen Seth Hanig via cfe-commits]

https://github.com/naveen-seth updated https://github.com/llvm/llvm-project/pull/190142

>From 42f89c5eb754b978c3a9b868df56360f9d601675 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig <naveen.hanig at outlook.com>
Date: Thu, 2 Apr 2026 11:09:47 +0200
Subject: [PATCH 1/2] [clang][moduels-driver] Avoid copy of -cc1 command &
 const correctness (NFC)

---
 clang/lib/Driver/ModulesDriver.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/clang/lib/Driver/ModulesDriver.cpp b/clang/lib/Driver/ModulesDriver.cpp
index bbad357be0aa1..f19cd74d83289 100644
--- a/clang/lib/Driver/ModulesDriver.cpp
+++ b/clang/lib/Driver/ModulesDriver.cpp
@@ -1231,11 +1231,11 @@ createClangModulePrecompileJob(Compilation &C, const Command &ImportingJob,
   Action *PA = C.MakeAction<PrecompileJobAction>(IA, types::ID::TY_ModuleFile);
   PA->propagateOffloadInfo(&ImportingJob.getSource());
 
-  auto &TC = ImportingJob.getCreator().getToolChain();
-  auto &TCArgs = C.getArgsForToolChain(&TC, PA->getOffloadingArch(),
-                                       PA->getOffloadingDeviceKind());
+  const auto &TC = ImportingJob.getCreator().getToolChain();
+  const auto &TCArgs = C.getArgsForToolChain(
+      &TC, PA->getOffloadingArch(), PA->getOffloadingDeviceKind());
 
-  auto BuildArgs = MD.getBuildArguments();
+  const auto &BuildArgs = MD.getBuildArguments();
   ArgStringList JobArgs;
   JobArgs.reserve(BuildArgs.size());
   for (const auto &Arg : BuildArgs)

>From 08fe776892b50069a63daeeb055f4fc83447d2ac Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig <naveen.hanig at outlook.com>
Date: Thu, 2 Apr 2026 12:12:41 +0200
Subject: [PATCH 2/2] Fix formatting

---
 clang/lib/Driver/ModulesDriver.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/lib/Driver/ModulesDriver.cpp b/clang/lib/Driver/ModulesDriver.cpp
index f19cd74d83289..2cd274a1f3099 100644
--- a/clang/lib/Driver/ModulesDriver.cpp
+++ b/clang/lib/Driver/ModulesDriver.cpp
@@ -1232,8 +1232,8 @@ createClangModulePrecompileJob(Compilation &C, const Command &ImportingJob,
   PA->propagateOffloadInfo(&ImportingJob.getSource());
 
   const auto &TC = ImportingJob.getCreator().getToolChain();
-  const auto &TCArgs = C.getArgsForToolChain(
-      &TC, PA->getOffloadingArch(), PA->getOffloadingDeviceKind());
+  const auto &TCArgs = C.getArgsForToolChain(&TC, PA->getOffloadingArch(),
+                                             PA->getOffloadingDeviceKind());
 
   const auto &BuildArgs = MD.getBuildArguments();
   ArgStringList JobArgs;