[clang] [clang][modules-driver] Avoid copy of -cc1 command & const correctness (NFC) (PR #190142)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 2 03:08:08 PDT 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Naveen Seth Hanig (naveen-seth)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/190142.diff
1 Files Affected:
- (modified) clang/lib/Driver/ModulesDriver.cpp (+4-4)
``````````diff
diff --git a/clang/lib/Driver/ModulesDriver.cpp b/clang/lib/Driver/ModulesDriver.cpp
index bbad357be0aa1..f19cd74d83289 100644
--- a/clang/lib/Driver/ModulesDriver.cpp
+++ b/clang/lib/Driver/ModulesDriver.cpp
@@ -1231,11 +1231,11 @@ createClangModulePrecompileJob(Compilation &C, const Command &ImportingJob,
Action *PA = C.MakeAction<PrecompileJobAction>(IA, types::ID::TY_ModuleFile);
PA->propagateOffloadInfo(&ImportingJob.getSource());
- auto &TC = ImportingJob.getCreator().getToolChain();
- auto &TCArgs = C.getArgsForToolChain(&TC, PA->getOffloadingArch(),
- PA->getOffloadingDeviceKind());
+ const auto &TC = ImportingJob.getCreator().getToolChain();
+ const auto &TCArgs = C.getArgsForToolChain(
+ &TC, PA->getOffloadingArch(), PA->getOffloadingDeviceKind());
- auto BuildArgs = MD.getBuildArguments();
+ const auto &BuildArgs = MD.getBuildArguments();
ArgStringList JobArgs;
JobArgs.reserve(BuildArgs.size());
for (const auto &Arg : BuildArgs)
``````````
</details>
https://github.com/llvm/llvm-project/pull/190142
More information about the cfe-commits
mailing list