[clang] [CIR] Fix incorrect CIR_GlobalOp.global_visibility assembly format (PR #189673)

via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 1 11:01:02 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,c -- clang/test/CIR/CodeGen/attribute-visibility.c clang/lib/CIR/Dialect/IR/CIRDialect.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
index 1187fd5dd..dbe064f03 100644
--- a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
+++ b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
@@ -223,10 +223,11 @@ void printVisibilityAttr(OpAsmPrinter &printer,
 
 void printVisibilityAttr(OpAsmPrinter &printer, cir::GlobalOp,
                          cir::VisibilityAttr visibility) {
-    printVisibilityAttr(printer, visibility);
+  printVisibilityAttr(printer, visibility);
 }
 
-mlir::OptionalParseResult parseVisibilityAttr(OpAsmParser &parser, cir::VisibilityAttr &visibility) {
+mlir::OptionalParseResult parseVisibilityAttr(OpAsmParser &parser,
+                                              cir::VisibilityAttr &visibility) {
   cir::VisibilityKind visibilityKind =
       parseOptionalCIRKeyword(parser, cir::VisibilityKind::Default);
   visibility = cir::VisibilityAttr::get(parser.getContext(), visibilityKind);

``````````

</details>


https://github.com/llvm/llvm-project/pull/189673


More information about the cfe-commits mailing list