[clang] [HLSL] Rewrite inline HLSL intrinsics into TableGen (PR #188362)

Justin Bogner via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 31 22:41:15 PDT 2026


================
@@ -313,8 +313,355 @@ class HLSLOneArgInlineBuiltin<string name> : HLSLBuiltin<name> {
 // Intrinsic definitions (sorted alphabetically by function name)
 //===----------------------------------------------------------------------===//
 
-// TODO: Convert hand-written overloads from hlsl_intrinsics.h and
-//       hlsl_alias_intrinsics.h into TableGen below.
-//       Include "hlsl_alias_intrinsics_gen.inc" in hlsl_alias_intrinsics.h
-//       Include "hlsl_inline_intrinsics_gen.inc" in hlsl_intrinsics.h
+// Unsigned abs is a constexpr identity — unsigned values are already non-negative.
----------------
bogner wrote:

Generally these comments feel kind of redundant with the comment in `Doc` below. Should we elide them all?

https://github.com/llvm/llvm-project/pull/188362


More information about the cfe-commits mailing list