[clang] Fix crash and improve diagnostics for void lambda returns (PR #188904)

[Kartik Ohlan via cfe-commits]

Ko496-glitch wrote:

@Sirraide  hey i am kind of confuse the test failure is working locally, i dont know why it's failing here, any suggestions ? 

ase) kartikohlan at Kartiks-MacBook-Pro build-release % llvm-lit clang/test/CXX/expr/expr.prim/expr.prim.lambda/p4.cpp
zsh: command not found: llvm-lit
(base) kartikohlan at Kartiks-MacBook-Pro build-release % ./bin/llvm-lit ../clang/test/CXX/expr/expr.prim/expr.prim.lambda/p4.cpp
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using clang: /Users/kartikohlan/llvm-project/build-release/bin/clang
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find apinotes-test in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find c-index-test in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find cir-opt in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find clang-diff in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find clang-format in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find clang-repl in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find llvm-objdump in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find llvm-offload-binary in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find clang-scan-deps in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find clang-installapi in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find opt in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find llvm-ifs in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find yaml2obj in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find clang-linker-wrapper in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find clang-nvlink-wrapper in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find clang-sycl-linker in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find llvm-lto in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find llvm-lto2 in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find llvm-profdata in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find llvm-readtapi in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find clang-ssaf-linker in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find clang-ssaf-format in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find clang-check in /Users/kartikohlan/llvm-project/build-release/bin:/Users/kartikohlan/llvm-project/build-release/bin
llvm-lit: /Users/kartikohlan/llvm-project/llvm/utils/lit/lit/util.py:363: note: using SDKROOT: '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.2.sdk'
-- Testing: 1 tests, 1 workers --
PASS: Clang :: CXX/expr/expr.prim/expr.prim.lambda/p4.cpp (1 of 1)

Testing Time: 0.33s

Total Discovered Tests: 1
  Passed: 1 (100.00%)


https://github.com/llvm/llvm-project/pull/188904