[clang] [llvm] [CMake] Version Darwin dylib identities (PR #189004)

[Steven Wu via cfe-commits]

cachemeifyoucan wrote:

> We will not, because we are using the -DLLVM_VERSION_SUFFIX and linking to the dynamic library with that specific suffix. That's a bulletproof solution on Linux, that is used also by Rust compiler as well. If you look at the latest libLLVM tarballs that Rust uses (e.g. https://ci-artifacts.rust-lang.org/rustc-builds/80d0e4be6f15899649ba31669077c59a986f96cc/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz), you can see:

That is because you always link against versioned dylib. That won't work if linked against base version. I was referring to the hack inside the issue referenced, not the general versioned technique. I am just not convinced we should do this from the GitHub issue mentioned. Would like to see if there are other issues.



https://github.com/llvm/llvm-project/pull/189004