[clang] [analyzer] Resolve initializers for fields of struct array elements i… (PR #189361)

[Balázs Benics via cfe-commits]

================
@@ -2145,6 +2145,46 @@ SVal RegionStoreManager::getBindingForField(RegionBindingsConstRef B,
         }
   }
 
+  // In case of array of structs, the super-region is not directly a VarRegion,
+  // instead there is another layer of ElementRegion in between them, i.e.:
+  // FieldRegion(ElementRegion(VarRegion)).
+  if (const auto *ER = dyn_cast<ElementRegion>(superR)) {
+    if (const auto *VR = dyn_cast<VarRegion>(ER->getSuperRegion())) {
+      const VarDecl *VD = VR->getDecl();
+      QualType ArrayTy = VD->getType();
+      unsigned FieldIdx = FD->getFieldIndex();
+
+      if (ArrayTy.isConstQualified() || Ty.isConstQualified() ||
+          (B.isMainAnalysis() && VD->hasGlobalStorage())) {
----------------
steakhal wrote:

I couldn't find a predicate on the language standard. This is only correct for C, and not for C++ where the global variable constructors can have side-effects.

https://github.com/llvm/llvm-project/pull/189361