[clang] [clang][analyzer] Forward CTU-import failure conditions (PR #189064)

Arseniy Zaostrovnykh via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 30 05:40:22 PDT 2026


================
@@ -191,6 +191,24 @@ TEST(CrossTranslationUnit, EmptyInvocationListIsNotValid) {
   EXPECT_TRUE(IsWrongFromatError);
 }
 
+TEST(CrossTranslationUnit, WrongFormatInvocationListHasLineNumber) {
----------------
necto wrote:

I find this unit is smaller and more focused: it involves less machinery than a LIT test, and it checks only one property. It would provide a better signal when fails, as compared to clang/test/Analysis/ctu/diag/invlist-wrong-format-late.cpp because it us more restricted, and it should be easier to debug.

I find it also shorter and more clear especially after

67de200d9a69 Shorter unit test

That being said, it is kind of redundant with invlist-wrong-format-late.cpp
Shall I drop this unit test or invlist-wrong-format-late.cpp to avoid redundant testing?

https://github.com/llvm/llvm-project/pull/189064


More information about the cfe-commits mailing list