[clang] [llvm] [CoroSplit] Erase trivially dead allocas after spilling (PR #189295)

[LLVM Continuous Integration via cfe-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-hwasan` running on `sanitizer-buildbot12` while building `clang,llvm` at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/26078

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/main.py:74: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 96339 tests, 72 workers --
Testing:  0.. 
FAIL: Clang :: CodeGenCXX/type-aware-coroutines.cpp (11005 of 96339)
******************** TEST 'Clang :: CodeGenCXX/type-aware-coroutines.cpp' FAILED ********************
Exit Code: 2

Command Output (stdout):
--
# RUN: at line 1
/home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/lib/clang/23/include -nostdsysteminc -triple arm64-apple-macosx  /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp -std=c++23 -fcoroutines -fexceptions -emit-llvm  -Wno-coro-type-aware-allocation-function -o - | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/FileCheck /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp
# executed command: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/lib/clang/23/include -nostdsysteminc -triple arm64-apple-macosx /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp -std=c++23 -fcoroutines -fexceptions -emit-llvm -Wno-coro-type-aware-allocation-function -o -
# .---command stderr------------
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:21:11: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |    21 |     void *operator new(std::type_identity<promise_type>, std::size_t sz, std::align_val_t, int);
# |       |           ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:22:11: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |    22 |     void *operator new(std::type_identity<promise_type>, std::size_t sz, std::align_val_t, float);
# |       |           ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:23:10: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |    23 |     void operator delete(std::type_identity<promise_type>, void *, std::size_t sz, std::align_val_t);
# |       |          ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:24:32: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |    24 |     template <typename T> void operator delete(std::type_identity<T>, void *, std::size_t sz, std::align_val_t) = delete;
# |       |                                ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:40:39: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |    40 |     template <typename... Args> void *operator new(std::type_identity<promise_type>, std::size_t sz, std::align_val_t, Args...);
# |       |                                       ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:41:10: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |    41 |     void operator delete(std::type_identity<promise_type>, void *, std::size_t sz, std::align_val_t);
# |       |          ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:103:29: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |   103 | template <typename T> void *operator new(std::type_identity<T>, std::size_t sz, std::align_val_t);
# |       |                             ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:104:47: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |   104 | template <typename T, typename... Args> void *operator new(std::type_identity<T>, std::size_t sz, std::align_val_t, Args...);
# |       |                                               ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:105:28: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |   105 | template <typename T> void operator delete(std::type_identity<T>, void *, std::size_t sz, std::align_val_t);
# |       |                            ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:106:46: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |   106 | template <typename T, typename... Args> void operator delete(std::type_identity<T>, void *, std::size_t sz, std::align_val_t, Args...);
Step 11 (stage2/hwasan check) failure: stage2/hwasan check (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:569: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/main.py:74: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 96339 tests, 72 workers --
Testing:  0.. 
FAIL: Clang :: CodeGenCXX/type-aware-coroutines.cpp (11005 of 96339)
******************** TEST 'Clang :: CodeGenCXX/type-aware-coroutines.cpp' FAILED ********************
Exit Code: 2

Command Output (stdout):
--
# RUN: at line 1
/home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/lib/clang/23/include -nostdsysteminc -triple arm64-apple-macosx  /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp -std=c++23 -fcoroutines -fexceptions -emit-llvm  -Wno-coro-type-aware-allocation-function -o - | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/FileCheck /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp
# executed command: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/lib/clang/23/include -nostdsysteminc -triple arm64-apple-macosx /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp -std=c++23 -fcoroutines -fexceptions -emit-llvm -Wno-coro-type-aware-allocation-function -o -
# .---command stderr------------
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:21:11: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |    21 |     void *operator new(std::type_identity<promise_type>, std::size_t sz, std::align_val_t, int);
# |       |           ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:22:11: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |    22 |     void *operator new(std::type_identity<promise_type>, std::size_t sz, std::align_val_t, float);
# |       |           ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:23:10: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |    23 |     void operator delete(std::type_identity<promise_type>, void *, std::size_t sz, std::align_val_t);
# |       |          ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:24:32: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |    24 |     template <typename T> void operator delete(std::type_identity<T>, void *, std::size_t sz, std::align_val_t) = delete;
# |       |                                ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:40:39: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |    40 |     template <typename... Args> void *operator new(std::type_identity<promise_type>, std::size_t sz, std::align_val_t, Args...);
# |       |                                       ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:41:10: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |    41 |     void operator delete(std::type_identity<promise_type>, void *, std::size_t sz, std::align_val_t);
# |       |          ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:103:29: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |   103 | template <typename T> void *operator new(std::type_identity<T>, std::size_t sz, std::align_val_t);
# |       |                             ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:104:47: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |   104 | template <typename T, typename... Args> void *operator new(std::type_identity<T>, std::size_t sz, std::align_val_t, Args...);
# |       |                                               ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:105:28: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |   105 | template <typename T> void operator delete(std::type_identity<T>, void *, std::size_t sz, std::align_val_t);
# |       |                            ^
# | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/CodeGenCXX/type-aware-coroutines.cpp:106:46: warning: type aware allocators are a Clang extension [-Wext-cxx-type-aware-allocators]
# |   106 | template <typename T, typename... Args> void operator delete(std::type_identity<T>, void *, std::size_t sz, std::align_val_t, Args...);

```

</details>

https://github.com/llvm/llvm-project/pull/189295