[clang] [clang] Introduce `ModuleCache::write()` (PR #188877)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ModuleCache.cpp.obj</summary>

```
FAILED: [code=1] tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ModuleCache.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\clang\lib\Serialization -IC:\_work\llvm-project\llvm-project\clang\lib\Serialization -IC:\_work\llvm-project\llvm-project\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\clang\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\clang\lib\Serialization\CMakeFiles\obj.clangSerialization.dir\ModuleCache.cpp.obj /Fdtools\clang\lib\Serialization\CMakeFiles\obj.clangSerialization.dir\ -c -- C:\_work\llvm-project\llvm-project\clang\lib\Serialization\ModuleCache.cpp
In file included from C:\_work\llvm-project\llvm-project\clang\lib\Serialization\ModuleCache.cpp:9:
C:\_work\llvm-project\llvm-project\clang\include\clang/Serialization/ModuleCache.h(57,16): error: no type named 'error_code' in namespace 'std'
57 |   virtual std::error_code write(StringRef Path,
|           ~~~~~^
C:\_work\llvm-project\llvm-project\clang\include\clang/Serialization/ModuleCache.h(75,6): error: no type named 'error_code' in namespace 'std'
75 | std::error_code writeImpl(StringRef Path, llvm::MemoryBufferRef Buffer);
| ~~~~~^
C:\_work\llvm-project\llvm-project\clang\lib\Serialization\ModuleCache.cpp(193,71): error: only virtual member functions can be marked 'override'
193 |   std::error_code write(StringRef Path, llvm::MemoryBufferRef Buffer) override {
|                                                                       ^~~~~~~~
3 errors generated.
```
</details>
<details>
<summary>[code=1] tools/clang/lib/DependencyScanning/CMakeFiles/obj.clangDependencyScanning.dir/InProcessModuleCache.cpp.obj</summary>

```
FAILED: [code=1] tools/clang/lib/DependencyScanning/CMakeFiles/obj.clangDependencyScanning.dir/InProcessModuleCache.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\clang\lib\DependencyScanning -IC:\_work\llvm-project\llvm-project\clang\lib\DependencyScanning -IC:\_work\llvm-project\llvm-project\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\clang\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\clang\lib\DependencyScanning\CMakeFiles\obj.clangDependencyScanning.dir\InProcessModuleCache.cpp.obj /Fdtools\clang\lib\DependencyScanning\CMakeFiles\obj.clangDependencyScanning.dir\ -c -- C:\_work\llvm-project\llvm-project\clang\lib\DependencyScanning\InProcessModuleCache.cpp
In file included from C:\_work\llvm-project\llvm-project\clang\lib\DependencyScanning\InProcessModuleCache.cpp:9:
In file included from C:\_work\llvm-project\llvm-project\clang\include\clang/DependencyScanning/InProcessModuleCache.h:12:
C:\_work\llvm-project\llvm-project\clang\include\clang/Serialization/ModuleCache.h(57,16): error: no type named 'error_code' in namespace 'std'
57 |   virtual std::error_code write(StringRef Path,
|           ~~~~~^
C:\_work\llvm-project\llvm-project\clang\include\clang/Serialization/ModuleCache.h(75,6): error: no type named 'error_code' in namespace 'std'
75 | std::error_code writeImpl(StringRef Path, llvm::MemoryBufferRef Buffer);
| ~~~~~^
C:\_work\llvm-project\llvm-project\clang\lib\DependencyScanning\InProcessModuleCache.cpp(130,71): error: only virtual member functions can be marked 'override'
130 |   std::error_code write(StringRef Path, llvm::MemoryBufferRef Buffer) override {
|                                                                       ^~~~~~~~
3 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/188877