[clang] [llvm] [HLSL][SPIRV] Add support for -g to generate NonSemantic Debug Info (PR #187051)

[Diego Novillo via cfe-commits]

dnovillo wrote:

> Hi @dnovillo 
> We are seeing a few failures on our builder after this change (comment above is our builder)
> 
> ```
> ******************** TEST 'libomptarget :: spirv64-intel :: sanitizer/free_wrong_ptr_kind.c' FAILED ********************
> Exit Code: 1
> Command Output (stdout):
> --
> # RUN: at line 2
> /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./bin/clang -fopenmp    -I /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/llvm-project/offload/test -I /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/openmp/runtime/src -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/openmp/runtime/src  -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib  -fopenmp-targets=spirv64-intel -O3 /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/llvm-project/offload/test/sanitizer/free_wrong_ptr_kind.c -o /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload/test/spirv64-intel/sanitizer/Output/free_wrong_ptr_kind.c.tmp
> # executed command: /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./bin/clang -fopenmp -I /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/llvm-project/offload/test -I /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/openmp/runtime/src -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -fopenmp-targets=spirv64-intel -O3 /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/llvm-project/offload/test/sanitizer/free_wrong_ptr_kind.c -o /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload/test/spirv64-intel/sanitizer/Output/free_wrong_ptr_kind.c.tmp
> # RUN: at line 3
> /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./bin/not --crash env -u LLVM_DISABLE_SYMBOLIZATION OFFLOAD_TRACK_ALLOCATION_TRACES=1 /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload/test/spirv64-intel/sanitizer/Output/free_wrong_ptr_kind.c.tmp 2>&1 | /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./bin/FileCheck /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/llvm-project/offload/test/sanitizer/free_wrong_ptr_kind.c --check-prefixes=CHECK,NDEBG
> # executed command: /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./bin/not --crash env -u LLVM_DISABLE_SYMBOLIZATION OFFLOAD_TRACK_ALLOCATION_TRACES=1 /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload/test/spirv64-intel/sanitizer/Output/free_wrong_ptr_kind.c.tmp
> # executed command: /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./bin/FileCheck /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/llvm-project/offload/test/sanitizer/free_wrong_ptr_kind.c --check-prefixes=CHECK,NDEBG
> # RUN: at line 4
> /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./bin/clang -fopenmp    -I /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/llvm-project/offload/test -I /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/openmp/runtime/src -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/openmp/runtime/src  -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib  -fopenmp-targets=spirv64-intel -O3 /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/llvm-project/offload/test/sanitizer/free_wrong_ptr_kind.c -o /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload/test/spirv64-intel/sanitizer/Output/free_wrong_ptr_kind.c.tmp -g
> # executed command: /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./bin/clang -fopenmp -I /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/llvm-project/offload/test -I /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/openmp/runtime/src -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -L /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -Wl,-rpath,/home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/./lib -fopenmp-targets=spirv64-intel -O3 /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/llvm-project/offload/test/sanitizer/free_wrong_ptr_kind.c -o /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/runtimes/runtimes-bins/offload/test/spirv64-intel/sanitizer/Output/free_wrong_ptr_kind.c.tmp -g
> # .---command stderr------------
> # | fatal error: error in backend: Unable to meet SPIR-V requirements for this target.
> # | clang: error: clang frontend command failed with exit code 70 (use -v to see invocation)
> # | clang version 23.0.0git (https://github.com/llvm/llvm-project.git 85049fc357ac3917350b97f4812209d9d00fe808)
> # | Target: x86_64-unknown-linux-gnu
> # | Thread model: posix
> # | InstalledDir: /home/test-user/llvm-buildbot-worker/intel-sycl-gpu/build/bin
> # | Build config: +assertions
> # | clang: note: diagnostic msg: 
> # | ********************
> # | 
> # | PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
> # | Preprocessed source(s) and associated run script(s) are located at:
> # | clang: note: diagnostic msg: /tmp/lit-tmp-duy2ovua/free_wrong_ptr_kind-2ef2e3.c
> # | clang: note: diagnostic msg: /tmp/lit-tmp-duy2ovua/free_wrong_ptr_kind-18d5a7.c
> # | clang: note: diagnostic msg: /tmp/lit-tmp-duy2ovua/free_wrong_ptr_kind-2ef2e3.sh
> # | clang: note: diagnostic msg: 
> # | 
> # | ********************
> # `-----------------------------
> # error: command failed with exit status: 1
> --
> ********************
> ```
> ```
> fatal error: error in backend: Unable to meet SPIR-V requirements for this target.
> ```
> Seems to be the error message.
> 
> Can you take a look and revert your change if the fix isn't simple? Thanks

Yeah, sorry about that. I tried reproducing with the exact flags used by the CI bot, but on my system these tests are marked UNSUPPORTED.

Maybe I'm missing an external dependency? Not sure how to reproduce. Alternately, if I could get those files mentioned in the crash message that could help. 

In the meantime, yes, rolling back this PR is the right thing to do. I don't have write access to the repo, though. How can I roll it back? 


Thanks. Diego. 

https://github.com/llvm/llvm-project/pull/187051