[libclc] libclc: Fix missing overloads for atomic_fetch_add/sub (PR #188478)

via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 25 06:52:43 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cl -- libclc/opencl/lib/generic/atomic/atomic_fetch_add.cl libclc/opencl/lib/generic/atomic/atomic_fetch_sub.cl --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libclc/opencl/lib/generic/atomic/atomic_fetch_add.cl b/libclc/opencl/lib/generic/atomic/atomic_fetch_add.cl
index e399afef9..e356991df 100644
--- a/libclc/opencl/lib/generic/atomic/atomic_fetch_add.cl
+++ b/libclc/opencl/lib/generic/atomic/atomic_fetch_add.cl
@@ -43,8 +43,9 @@ _CLC_OVERLOAD _CLC_DEF uintptr_t atomic_fetch_add(volatile atomic_uintptr_t *p,
 #endif // _CLC_GENERIC_AS_SUPPORTED
 #endif // __opencl_c_atomic_order_seq_cst
 
-_CLC_OVERLOAD _CLC_DEF uintptr_t atomic_fetch_add(
-    volatile __local atomic_uintptr_t *p, ptrdiff_t v, memory_order order) {
+_CLC_OVERLOAD
+    _CLC_DEF uintptr_t atomic_fetch_add(volatile __local atomic_uintptr_t *p,
+                                        ptrdiff_t v, memory_order order) {
   return __scoped_atomic_fetch_add((volatile __local uintptr_t *)p, v, order,
                                    __MEMORY_SCOPE_DEVICE);
 }
diff --git a/libclc/opencl/lib/generic/atomic/atomic_fetch_sub.cl b/libclc/opencl/lib/generic/atomic/atomic_fetch_sub.cl
index f639a7179..37ddf7a71 100644
--- a/libclc/opencl/lib/generic/atomic/atomic_fetch_sub.cl
+++ b/libclc/opencl/lib/generic/atomic/atomic_fetch_sub.cl
@@ -43,8 +43,9 @@ _CLC_OVERLOAD _CLC_DEF uintptr_t atomic_fetch_sub(volatile atomic_uintptr_t *p,
 #endif // _CLC_GENERIC_AS_SUPPORTED
 #endif // __opencl_c_atomic_order_seq_cst
 
-_CLC_OVERLOAD _CLC_DEF uintptr_t atomic_fetch_sub(
-    volatile __local atomic_uintptr_t *p, ptrdiff_t v, memory_order order) {
+_CLC_OVERLOAD
+    _CLC_DEF uintptr_t atomic_fetch_sub(volatile __local atomic_uintptr_t *p,
+                                        ptrdiff_t v, memory_order order) {
   return __scoped_atomic_fetch_sub((volatile __local uintptr_t *)p, v, order,
                                    __MEMORY_SCOPE_DEVICE);
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/188478


More information about the cfe-commits mailing list