[clang-tools-extra] Symbol tags in SymbolInformation, WorkspaceSymbol, CallHierarchyItem and TypeHierarchyItem (PR #170103)

[via cfe-commits]

================
@@ -1126,6 +1127,9 @@ const Symbol *SymbolCollector::addDeclaration(const NamedDecl &ND, SymbolID ID,
       S.Documentation = Documentation;
     }
   };
+
+  S.Tags = computeSymbolTags(ND);
----------------
timon-ul wrote:

You are calling this in both, `addDeclaration` and `addDefinition`, I think it should be only called once, so either remove this call (probably ok?), or add some guard before the second call. Also this call feels a bit out of place here, I would suggest moving it above the computation of the completion information.

https://github.com/llvm/llvm-project/pull/170103