[clang] [clang][bytecode] Disable tail calls on MSVC (PR #188033)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Timm Baeder (tbaederr)

<details>
<summary>Changes</summary>

Since I now have to wait for CI to do a revert, might as well to the actual change first.

---
Full diff: https://github.com/llvm/llvm-project/pull/188033.diff


1 Files Affected:

- (modified) clang/lib/AST/ByteCode/Interp.cpp (+3-1) 


``````````diff
diff --git a/clang/lib/AST/ByteCode/Interp.cpp b/clang/lib/AST/ByteCode/Interp.cpp
index 6e7a60d5e4332..abe7b31082302 100644
--- a/clang/lib/AST/ByteCode/Interp.cpp
+++ b/clang/lib/AST/ByteCode/Interp.cpp
@@ -37,7 +37,9 @@ using namespace clang::interp;
 #endif
 
 // On MSVC, musttail does not guarantee tail calls in debug mode.
-#if (defined(_MSC_VER) && defined(_DEBUG)) || !defined(MUSTTAIL)
+// We disable it on MSVC generally since it doesn't seem to be able
+// to handle the way we use tailcalls.
+#if defined(_MSC_VER) || !defined(MUSTTAIL)
 #define MUSTTAIL
 #define USE_TAILCALLS 0
 #else

``````````

</details>


https://github.com/llvm/llvm-project/pull/188033