[clang] [clang][ModulesDriver] Fix build failure with Xcode 14 (PR #187713)
Naveen Seth Hanig via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 20 07:47:41 PDT 2026
https://github.com/naveen-seth created https://github.com/llvm/llvm-project/pull/187713
As pointed out by https://github.com/llvm/llvm-project/pull/152770#issuecomment-4096179622, 81e8a1e causes build errors with older versions of Xcode (Xcode 14 and older).
This implements the same fix as described in d1d9413.
>From a892a0cfca7dad570bae4ee38b0b6777cb254c13 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig <naveen.hanig at outlook.com>
Date: Fri, 20 Mar 2026 15:37:13 +0100
Subject: [PATCH] [clang][ModulesDriver] Fix build failure with Xcode 14
As pointed out by
https://github.com/llvm/llvm-project/pull/152770#issuecomment-4096179622,
81e8a1e causes build errors with older versions of Xcode (Xcode 14 and
older).
This implements the same fix as described in d1d9413.
---
clang/lib/Driver/ModulesDriver.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/clang/lib/Driver/ModulesDriver.cpp b/clang/lib/Driver/ModulesDriver.cpp
index 8740f9615d304..bbad357be0aa1 100644
--- a/clang/lib/Driver/ModulesDriver.cpp
+++ b/clang/lib/Driver/ModulesDriver.cpp
@@ -1412,8 +1412,7 @@ pruneUnusedStdlibModuleJobs(CompilationGraph &Graph,
llvm::map_range(llvm::depth_first(cast<CGNode>(PrunableJobNodeRoot)),
llvm::CastTo<JobNode>);
auto ReachableNonImageNodes = llvm::make_filter_range(
- ReachableJobNodes, std::not_fn(llvm::IsaPred<ImageJobNode>));
-
+ ReachableJobNodes, [](auto *N) { return !llvm::isa<ImageJobNode>(N); });
PrunableJobNodes.insert_range(ReachableNonImageNodes);
}
More information about the cfe-commits
mailing list