[clang-tools-extra] [clangd] [C++ Modules] Enable content validation for module input files (PR #187653)

via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 20 00:48:17 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang-tools-extra/clangd/ModulesBuilder.cpp clang-tools-extra/clangd/unittests/PrerequisiteModulesTest.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang-tools-extra/clangd/ModulesBuilder.cpp b/clang-tools-extra/clangd/ModulesBuilder.cpp
index 387fe7ce0..612c25b61 100644
--- a/clang-tools-extra/clangd/ModulesBuilder.cpp
+++ b/clang-tools-extra/clangd/ModulesBuilder.cpp
@@ -268,15 +268,16 @@ bool IsModuleFileUpToDate(PathRef ModuleFilePath,
   std::shared_ptr<ModuleCache> ModCache = createCrossProcessModuleCache();
   PCHContainerOperations PCHOperations;
   CodeGenOptions CodeGenOpts;
-  ASTReader Reader(PP, *ModCache, /*ASTContext=*/nullptr,
-                   PCHOperations.getRawReader(), CodeGenOpts, {},
-                   /*isysroot=*/"",
-                   /*DisableValidationKind=*/DisableValidationForModuleKind::None,
-                   /*AllowASTWithCompilerErrors=*/false,
-                   /*AllowConfigurationMismatch=*/false,
-                   /*ValidateSystemInputs=*/false,
-                   /*ForceValidateUserInputs=*/true,
-                   /*ValidateASTInputFilesContent=*/true);
+  ASTReader Reader(
+      PP, *ModCache, /*ASTContext=*/nullptr, PCHOperations.getRawReader(),
+      CodeGenOpts, {},
+      /*isysroot=*/"",
+      /*DisableValidationKind=*/DisableValidationForModuleKind::None,
+      /*AllowASTWithCompilerErrors=*/false,
+      /*AllowConfigurationMismatch=*/false,
+      /*ValidateSystemInputs=*/false,
+      /*ForceValidateUserInputs=*/true,
+      /*ValidateASTInputFilesContent=*/true);
 
   // We don't need any listener here. By default it will use a validator
   // listener.

``````````

</details>


https://github.com/llvm/llvm-project/pull/187653


More information about the cfe-commits mailing list