[clang] [clang-tools-extra] [clang][modules] Stop uniquing implicit modules via `FileEntry` (PR #185765)
Michael Park via cfe-commits
cfe-commits at lists.llvm.org
Sat Mar 14 00:41:01 PDT 2026
================
@@ -13,11 +13,9 @@
// RUN: -Wno-experimental-header-units -fmodule-file=hu-01.pcm -o hu-02-rel.pcm \
// RUN: -fmodule-file-home-is-cwd
-// RUN: %clang -module-file-info hu-02-abs.pcm | FileCheck %s --check-prefix=IMPORT-ABS -DPREFIX=%t
-// IMPORT-ABS: Imports module 'hu-01': [[PREFIX]]{{/|\\}}hu-01.pcm
-
-// RUN: %clang -module-file-info hu-02-rel.pcm | FileCheck %s --check-prefix=IMPORT-REL
-// IMPORT-REL: Imports module 'hu-01': hu-01.pcm
+// RUN: %clang -module-file-info hu-02-abs.pcm | FileCheck %s --check-prefix=IMPORT
+// RUN: %clang -module-file-info hu-02-rel.pcm | FileCheck %s --check-prefix=IMPORT
+// IMPORT: Imports module 'hu-01': hu-01.pcm
----------------
mpark wrote:
Hm, I'm not sure I follow. It's intentional that with `-fmodule-file-is-home-cwd`, that the import paths in the pcm be relative. I maintained existing behavior without that flag which emitted a absolute path.
It looks like this change now makes it such that relative paths are always emitted or something? I'm not sure how/why this is an effect from your change 🤔
https://github.com/llvm/llvm-project/pull/185765
More information about the cfe-commits
mailing list