[clang] [clang][bytecode] Stop relying on `CheckEvaluationResult()` (PR #183706)

[Shafik Yaghmour via cfe-commits]

https://github.com/shafik commented:

So I did a run through but I started running out of steam about 60% through, it is large.

Is there anyway to split this into two changes: `EvalInfo` only and `EvaluationResult` only? It would make it way less of a burden to review, which I why I suspect no one has given feedback yet.

https://github.com/llvm/llvm-project/pull/183706