[clang] [Clang] Address feedback in PR183010 (PR #185608)

[Younan Zhang via cfe-commits]

================
@@ -1185,7 +1154,7 @@ static bool CheckConstraintSatisfaction(
     return false;
   }
 
-  if (TemplateArgsLists.isAnyArgInstantiationDependent(S.Context)) {
+  if (TemplateArgsLists.isAnyArgDependent(S.Context)) {
----------------
zyn0217 wrote:

> This is a bug in the clang implementation yes. We can't do satisfaction checking until we have replaced all template levels we are under. It would be ok, from an as-if-rule standpoint, to perform the satisfaction before, if it would not change the outcome, but this is not the case here.


Also note that GCC accepted that example too.

Maybe this worths a DR (@cor3ntin), but i don't think it should block us from fixing user-reported bugs.


https://github.com/llvm/llvm-project/pull/185608