[clang] [Clang] Address feedback in PR183010 (PR #185608)

[Matheus Izvekov via cfe-commits]

================
@@ -1185,7 +1154,7 @@ static bool CheckConstraintSatisfaction(
     return false;
   }
 
-  if (TemplateArgsLists.isAnyArgInstantiationDependent(S.Context)) {
+  if (TemplateArgsLists.isAnyArgDependent(S.Context)) {
----------------
mizvekov wrote:

This is a bug in the clang implementation yes. We can't do satisfaction checking until we have replaced all template levels we are under. It would be ok, from an as-if-rule standpoint, to perform the satisfaction before, if it would not change the outcome, but this is not the case here.

I suspected the patch causing it was the original PR from this one. You think some other patch caused it?

https://github.com/llvm/llvm-project/pull/185608