[libclc] [libclc][NFC] Change include style from <...> to "..." (PR #185788)

Michał Górny via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 11 05:53:21 PDT 2026


mgorny wrote:

I'm seeing a huge test regression after this change:

```
Start testing: Mar 11 12:51 UTC
----------------------------------------------------------
1/1 Testing: external-funcs-libclc-amdgcn-amd-amdhsa-llvm
1/1 Test: external-funcs-libclc-amdgcn-amd-amdhsa-llvm
Command: "/var/tmp/portage/llvm-core/libclc-23.0.0.9999/work/libclc/check_external_funcs.sh" "/var/tmp/portage/llvm-core/libclc-23.0.0.9999/work/libclc_build/amdgcn-amd-amdhsa-llvm/libclc.bc" "/usr/lib/llvm/23/bin"
Directory: /var/tmp/portage/llvm-core/libclc-23.0.0.9999/work/libclc
"external-funcs-libclc-amdgcn-amd-amdhsa-llvm" start time: Mar 11 12:51 UTC
Output:
----------------------------------------------------------
ERROR: 178 unresolved external functions detected in /var/tmp/portage/llvm-core/libclc-23.0.0.9999/work/libclc_build/amdgcn-amd-amdhsa-llvm/libclc.bc
declare hidden i32 @_Z15__clc_get_fencePv(ptr noundef) local_unnamed_addr #1
declare hidden ptr addrspace(1) @_Z15__clc_to_globalPv(ptr noundef) local_unnamed_addr #1
declare hidden ptr addrspace(3) @_Z14__clc_to_localPv(ptr noundef) local_unnamed_addr #1
declare hidden ptr addrspace(5) @_Z16__clc_to_privatePv(ptr noundef) local_unnamed_addr #1
declare hidden zeroext i8 @_Z9__clc_absc(i8 noundef signext) local_unnamed_addr #1
declare hidden <2 x i8> @_Z9__clc_absDv2_c(<2 x i8> noundef) local_unnamed_addr #1
declare hidden <3 x i8> @_Z9__clc_absDv3_c(<3 x i8> noundef) local_unnamed_addr #1
declare hidden <4 x i8> @_Z9__clc_absDv4_c(<4 x i8> noundef) local_unnamed_addr #1
declare hidden <8 x i8> @_Z9__clc_absDv8_c(<8 x i8> noundef) local_unnamed_addr #1
declare hidden <16 x i8> @_Z9__clc_absDv16_c(<16 x i8> noundef) local_unnamed_addr #1
[…]
```

…and so on. Basically, it looks like it broke symbol visibility completely.

https://github.com/llvm/llvm-project/pull/185788


More information about the cfe-commits mailing list