[clang] [CIR] Upstream ThreeWayCmpOp (PR #169963)

via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 10 12:03:36 PDT 2026


Hendrik =?utf-8?q?Hübner?=,hhuebner <hendrik.huebner18 at gmail.com>,hhuebner
 <hendrik.huebner18 at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/169963 at github.com>


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang/test/CIR/CodeGen/Inputs/std-compare.h clang/test/CIR/CodeGen/three-way-cmp.cpp clang/lib/CIR/CodeGen/CIRGenBuilder.h clang/lib/CIR/CodeGen/CIRGenExprAggregate.cpp clang/lib/CIR/Dialect/IR/CIRAttrs.cpp clang/lib/CIR/Dialect/IR/CIRDialect.cpp clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp b/clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp
index 6076a5f08..ac4a27917 100644
--- a/clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp
+++ b/clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp
@@ -1594,10 +1594,11 @@ void LoweringPreparePass::runOnOp(mlir::Operation *op) {
     lowerTrivialCopyCall(callOp);
   } else if (auto storeOp = dyn_cast<cir::StoreOp>(op)) {
     lowerStoreOfConstAggregate(storeOp);
-  } else if (auto fnOp = dyn_cast<cir::FuncOp>(op)) {=======
-    >>>>>>> 041cf9ff6b44 (fmt)
-    if (auto globalCtor = fnOp.getGlobalCtorPriority())
-      globalCtorList.emplace_back(fnOp.getName(), globalCtor.value());
+  } else if (auto fnOp = dyn_cast<cir::FuncOp>(op)) {
+    == == ==
+        = >>>>>>>
+          041cf9ff6b44(fmt) if (auto globalCtor = fnOp.getGlobalCtorPriority())
+              globalCtorList.emplace_back(fnOp.getName(), globalCtor.value());
     else if (auto globalDtor = fnOp.getGlobalDtorPriority())
       globalDtorList.emplace_back(fnOp.getName(), globalDtor.value());
   } else if (auto threeWayCmp = dyn_cast<cir::CmpThreeWayOp>(op)) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/169963


More information about the cfe-commits mailing list