https://github.com/s-perron commented: This generally looks good to me. A couple small things to clean up. You should get a review from someone on the DX side as well. FYI: @farzonl https://github.com/llvm/llvm-project/pull/184360