[clang] [clang] teach OpenCL to set the param addrspace before calling CG EmitParmDecl (PR #184264)

[Jameson Nash via cfe-commits]

================
@@ -4306,13 +4306,15 @@ void CodeGenFunction::EmitCfiCheckStub() {
   QualType QInt64Ty = C.getIntTypeForBitwidth(64, false);
 
   FunctionArgList FnArgs;
-  ImplicitParamDecl ArgCallsiteTypeId(C, QInt64Ty, ImplicitParamKind::Other);
-  ImplicitParamDecl ArgAddr(C, C.VoidPtrTy, ImplicitParamKind::Other);
-  ImplicitParamDecl ArgCFICheckFailData(C, C.VoidPtrTy,
-                                        ImplicitParamKind::Other);
-  FnArgs.push_back(&ArgCallsiteTypeId);
-  FnArgs.push_back(&ArgAddr);
-  FnArgs.push_back(&ArgCFICheckFailData);
+  auto *ArgCallsiteTypeId =
+      ImplicitParamDecl::Create(C, QInt64Ty, ImplicitParamKind::Other);
+  auto *ArgAddr =
+      ImplicitParamDecl::Create(C, C.VoidPtrTy, ImplicitParamKind::Other);
+  auto *ArgCFICheckFailData =
+      ImplicitParamDecl::Create(C, C.VoidPtrTy, ImplicitParamKind::Other);
+  FnArgs.push_back(ArgCallsiteTypeId);
+  FnArgs.push_back(ArgAddr);
+  FnArgs.push_back(ArgCFICheckFailData);
----------------
vtjnash wrote:

Sure, I can do that, thanks for explaining. All similar cases of FunctionArgList should be converted now to the improved style.

bumping for re-review or further questions

https://github.com/llvm/llvm-project/pull/184264