[clang] 4879f16 - [clang][bytecode] Check memberpointer exprs for errors (#185370)

[via cfe-commits]

Author: Timm Baeder
Date: 2026-03-09T10:10:00+01:00
New Revision: 4879f1612b0bacf33ee84f679dd5ded7ca70d08e

URL: https://github.com/llvm/llvm-project/commit/4879f1612b0bacf33ee84f679dd5ded7ca70d08e
DIFF: https://github.com/llvm/llvm-project/commit/4879f1612b0bacf33ee84f679dd5ded7ca70d08e.diff

LOG: [clang][bytecode] Check memberpointer exprs for errors (#185370)

Added: 
    

Modified: 
    clang/lib/AST/ByteCode/Compiler.cpp
    clang/test/AST/ByteCode/memberpointers.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/AST/ByteCode/Compiler.cpp b/clang/lib/AST/ByteCode/Compiler.cpp
index 6d8b84a83a4ad..42d137f097760 100644
--- a/clang/lib/AST/ByteCode/Compiler.cpp
+++ b/clang/lib/AST/ByteCode/Compiler.cpp
@@ -269,6 +269,8 @@ bool Compiler<Emitter>::VisitCastExpr(const CastExpr *CE) {
   }
 
   case CK_DerivedToBaseMemberPointer: {
+    if (CE->containsErrors())
+      return false;
     assert(classifyPrim(CE) == PT_MemberPtr);
     assert(classifyPrim(SubExpr) == PT_MemberPtr);
 
@@ -291,6 +293,8 @@ bool Compiler<Emitter>::VisitCastExpr(const CastExpr *CE) {
   }
 
   case CK_BaseToDerivedMemberPointer: {
+    if (CE->containsErrors())
+      return false;
     assert(classifyPrim(CE) == PT_MemberPtr);
     assert(classifyPrim(SubExpr) == PT_MemberPtr);
 
@@ -1106,6 +1110,9 @@ bool Compiler<Emitter>::VisitBinaryOperator(const BinaryOperator *BO) {
     return this->VisitFixedPointBinOp(BO);
 
   if (BO->isPtrMemOp()) {
+    if (BO->containsErrors())
+      return false;
+
     if (!this->visit(LHS))
       return false;
 

diff  --git a/clang/test/AST/ByteCode/memberpointers.cpp b/clang/test/AST/ByteCode/memberpointers.cpp
index fb489a1961434..e2a154914c83b 100644
--- a/clang/test/AST/ByteCode/memberpointers.cpp
+++ b/clang/test/AST/ByteCode/memberpointers.cpp
@@ -1,7 +1,7 @@
 // RUN: %clang_cc1 -std=c++14 -fexperimental-new-constant-interpreter -verify=expected,both %s
 // RUN: %clang_cc1 -std=c++23 -fexperimental-new-constant-interpreter -verify=expected,both %s
-// RUN: %clang_cc1 -std=c++14 -verify=ref,both %s
-// RUN: %clang_cc1 -std=c++23 -verify=ref,both %s
+// RUN: %clang_cc1 -std=c++14                                         -verify=ref,both      %s
+// RUN: %clang_cc1 -std=c++23                                         -verify=ref,both      %s
 
 namespace MemberPointers {
   struct A {
@@ -303,3 +303,14 @@ namespace Equality {
   constexpr int (T<17>::*deepm) = (int(T<10>::*))&T<30>::m;
   static_assert(deepm == &T<50>::m, "");
 }
+
+namespace Errors {
+#if __cplusplus >= 202302L
+  constexpr bool test1() {
+    X s; // both-error {{unknown type name}}
+    s.*bar(); // both-error {{use of undeclared identifier}}
+    return true;
+  }
+  static_assert(test1(), ""); // both-error {{not an integral constant expression}}
+#endif
+}