[clang] [Clang][Modules] Fix crash when redefining default template argument (PR #185237)

Younan Zhang via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 8 21:05:27 PDT 2026


================
@@ -2472,13 +2473,23 @@ bool Sema::CheckTemplateParameterList(TemplateParameterList *NewParams,
         NewDefaultLoc = NewTypeParm->getDefaultArgumentLoc();
         SawDefaultArgument = true;
 
-        if (!OldTypeParm->getOwningModule())
+        bool SameDefault =
+            getASTContext().isSameDefaultTemplateArgument(OldTypeParm,
+                                                          NewTypeParm);
----------------
zyn0217 wrote:

You're repeating the same pattern 3 times. Can you refactor it a bit?

https://github.com/llvm/llvm-project/pull/185237


More information about the cfe-commits mailing list