[clang] [clang] Replace `finish()` with destructors for `DiagnosticConsumer` (PR #183831)

Sat Mar 7 14:11:55 PST 2026

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vla` running on `linaro-g3-04` while building `clang` at step 6 "build stage 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/17/builds/14900

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build stage 1) failure: 'ninja' (failure)
...
[9412/9641] Linking CXX executable bin/llvm-jitlink
[9413/9641] Building CXX object tools/flang/lib/Evaluate/CMakeFiles/FortranEvaluate.dir/cmake_pch.hxx.pch
[9414/9641] Building CXX object tools/flang/tools/fir-lsp-server/CMakeFiles/fir-lsp-server.dir/fir-lsp-server.cpp.o
[9415/9641] Building CXX object tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/parsing.cpp.o
[9416/9641] Building CXX object tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/expr-parsers.cpp.o
[9417/9641] Building CXX object tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/openmp-utils.cpp.o
[9418/9641] Building CXX object tools/obj2yaml/CMakeFiles/obj2yaml.dir/elf2yaml.cpp.o
[9419/9641] Building CXX object tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/io-parsers.cpp.o
[9420/9641] Building CXX object tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/parse-tree.cpp.o
[9421/9641] Building CXX object tools/flang/tools/flang-driver/CMakeFiles/flang.dir/driver.cpp.o
FAILED: tools/flang/tools/flang-driver/CMakeFiles/flang.dir/driver.cpp.o 
/usr/local/bin/c++ -DFLANG_INCLUDE_TESTS=1 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/tools/flang/tools/flang-driver -I/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/flang/tools/flang-driver -I/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/flang/include -I/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/tools/flang/include -I/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/include -I/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/llvm/include -isystem /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/flang/../mlir/include -isystem /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/tools/mlir/include -isystem /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/tools/clang/include -isystem /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/llvm/../clang/include -mcpu=neoverse-512tvb -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Xclang -fno-pch-timestamp -Wno-deprecated-copy -Wno-string-conversion -Wno-ctad-maybe-unsupported -Wno-unused-command-line-argument -Wstring-conversion           -Wcovered-switch-default -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -Winvalid-pch -Xclang -include-pch -Xclang /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/lib/Support/CMakeFiles/LLVMSupport.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/lib/Support/CMakeFiles/LLVMSupport.dir/cmake_pch.hxx -MD -MT tools/flang/tools/flang-driver/CMakeFiles/flang.dir/driver.cpp.o -MF tools/flang/tools/flang-driver/CMakeFiles/flang.dir/driver.cpp.o.d -o tools/flang/tools/flang-driver/CMakeFiles/flang.dir/driver.cpp.o -c /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/flang/tools/flang-driver/driver.cpp
/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/flang/tools/flang-driver/driver.cpp:224:22: error: no member named 'finish' in 'clang::DiagnosticConsumer'
  224 |   diags.getClient()->finish();
      |   ~~~~~~~~~~~~~~~~~  ^
1 error generated.
[9422/9641] Building CXX object tools/flang/tools/flang-driver/CMakeFiles/flang.dir/fc1_main.cpp.o
[9423/9641] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/cmake_pch.hxx.pch
[9424/9641] Building CXX object tools/flang/lib/FrontendTool/CMakeFiles/flangFrontendTool.dir/ExecuteCompilerInvocation.cpp.o
[9425/9641] Building CXX object tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/openacc-parsers.cpp.o
[9426/9641] Building CXX object tools/llvm-readobj/CMakeFiles/llvm-readobj.dir/ELFDumper.cpp.o
[9427/9641] Building CXX object tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/program-parsers.cpp.o
[9428/9641] Building CXX object tools/flang/lib/Evaluate/CMakeFiles/FortranEvaluate.dir/call.cpp.o
[9429/9641] Building CXX object tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/executable-parsers.cpp.o
[9430/9641] Building CXX object tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/cmake_pch.hxx.pch
[9431/9641] Building CXX object tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/unparse.cpp.o
[9432/9641] Building CXX object tools/flang/lib/Lower/CMakeFiles/FortranLower.dir/cmake_pch.hxx.pch
[9433/9641] Building CXX object tools/flang/tools/f18-parse-demo/CMakeFiles/f18-parse-demo.dir/f18-parse-demo.cpp.o
[9434/9641] Building CXX object tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/Fortran-parsers.cpp.o
[9435/9641] Building CXX object tools/flang/lib/Evaluate/CMakeFiles/FortranEvaluate.dir/characteristics.cpp.o
[9436/9641] Building CXX object tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/openmp-parsers.cpp.o
[9437/9641] Building CXX object tools/flang/lib/Evaluate/CMakeFiles/FortranEvaluate.dir/check-expression.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/183831