[clang] [CIR] Fix convertSideEffectForCall header/definition signature mismatch (PR #185118)

via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 6 13:58:13 PST 2026


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clangir

@llvm/pr-subscribers-clang

Author: Henrich Lauko (xlauko)

<details>
<summary>Changes</summary>

Add missing bool &noReturn parameter to the declaration in
LowerToLLVM.h to match the definition in LowerToLLVM.cpp.

---
Full diff: https://github.com/llvm/llvm-project/pull/185118.diff


1 Files Affected:

- (modified) clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.h (+1-1) 


``````````diff
diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.h b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.h
index b7452797628c1..6133900c503b8 100644
--- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.h
+++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.h
@@ -33,7 +33,7 @@ mlir::LLVM::Linkage convertLinkage(cir::GlobalLinkageKind linkage);
 void convertSideEffectForCall(mlir::Operation *callOp, bool isNothrow,
                               cir::SideEffect sideEffect,
                               mlir::LLVM::MemoryEffectsAttr &memoryEffect,
-                              bool &noUnwind, bool &willReturn);
+                              bool &noUnwind, bool &willReturn, bool &noReturn);
 
 struct LLVMBlockAddressInfo {
   // Get the next tag index

``````````

</details>


https://github.com/llvm/llvm-project/pull/185118


More information about the cfe-commits mailing list