[clang] [llvm] Enable fexec-charset option (PR #138895)
Sergei Barannikov via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 5 23:25:12 PST 2026
================
@@ -7612,12 +7565,20 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
<< value;
}
- // -fexec_charset=UTF-8 is default. Reject others
- if (Arg *execCharset = Args.getLastArg(options::OPT_fexec_charset_EQ)) {
- StringRef value = execCharset->getValue();
- if (!value.equals_insensitive("utf-8"))
- D.Diag(diag::err_drv_invalid_value) << execCharset->getAsString(Args)
- << value;
+ if (Arg *ExecEncoding = Args.getLastArg(options::OPT_fexec_charset_EQ)) {
+ StringRef Value = ExecEncoding->getValue();
+ if (llvm::TextEncodingConverter::isEncodingSupported(Value)) {
+ CmdArgs.push_back("-fexec-charset");
+ CmdArgs.push_back(Args.MakeArgString(Value));
+ } else {
+ D.Diag(diag::err_drv_unsupported_encoding_for_target)
----------------
s-barannikov wrote:
This doesn't look target-dependent, change to `err_drv_unsupported` encoding (fixing the message accordingly)?
https://github.com/llvm/llvm-project/pull/138895
More information about the cfe-commits
mailing list