[clang-tools-extra] [clangd] Support suppressions for driver diagnostics (PR #182912)

Aleksandr Platonov via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 5 03:49:57 PST 2026


================
@@ -183,7 +183,7 @@ class StoreDiags : public DiagnosticConsumer {
 /// Determine whether a (non-clang-tidy) diagnostic is suppressed by config.
 bool isDiagnosticSuppressed(const clang::Diagnostic &Diag,
                             const llvm::StringSet<> &Suppressed,
-                            const LangOptions &);
+                            const std::optional<LangOptions> &);
----------------
ArcsinX wrote:

Sorry I didn't notice this initially. This function is only used within Diagnostics.cpp. So we can remove it from Diagnostics.h and move it to an anonymous namespace within Diagnostics.cpp or make it static.

https://github.com/llvm/llvm-project/pull/182912


More information about the cfe-commits mailing list