[clang] [llvm] Support -mnop-mcount and -mrecord-mcount on x86_64 elf targets. (PR #184641)

via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 4 08:40:10 PST 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions c,cpp -- clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/mnop-mcount.c clang/test/CodeGen/mrecord-mcount.c clang/test/Driver/mcount.c llvm/lib/Target/X86/X86ISelDAGToDAG.cpp llvm/lib/Target/X86/X86MCInstLower.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
index 2807be2c7..c58c2507c 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -6884,16 +6884,16 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
             << A->getAsString(Args) << TripleStr;
     }
     if (Arg *A = Args.getLastArg(options::OPT_mnop_mcount)) {
-      if (Arch == llvm::Triple::systemz || (TC.getTriple().isX86_64() &&
-			                    TC.getTriple().isOSBinFormatELF()))
+      if (Arch == llvm::Triple::systemz ||
+          (TC.getTriple().isX86_64() && TC.getTriple().isOSBinFormatELF()))
         A->render(Args, CmdArgs);
       else
         D.Diag(diag::err_drv_unsupported_opt_for_target)
             << A->getAsString(Args) << TripleStr;
     }
     if (Arg *A = Args.getLastArg(options::OPT_mrecord_mcount)) {
-      if (Arch == llvm::Triple::systemz || (TC.getTriple().isX86_64() &&
-			                    TC.getTriple().isOSBinFormatELF()))
+      if (Arch == llvm::Triple::systemz ||
+          (TC.getTriple().isX86_64() && TC.getTriple().isOSBinFormatELF()))
         A->render(Args, CmdArgs);
       else
         D.Diag(diag::err_drv_unsupported_opt_for_target)

``````````

</details>


https://github.com/llvm/llvm-project/pull/184641


More information about the cfe-commits mailing list