[clang] [Clang] Fix invalid sret addrspacecast for placement new on HIP (PR #183639)

[Matt Arsenault via cfe-commits]

================
@@ -286,8 +286,15 @@ void AggExprEmitter::withReturnValueSlot(
   // We need to always provide our own temporary if destruction is required.
   // Otherwise, EmitCall will emit its own, notice that it's "unused", and end
   // its lifetime before we have the chance to emit a proper destructor call.
-  bool UseTemp = Dest.isPotentiallyAliased() || Dest.requiresGCollection() ||
-                 (RequiresDestruction && Dest.isIgnored());
+  //
+  // We also need a temporary if the destination is in a different address space
+  // from the alloca AS, to avoid an invalid addrspacecast on the sret pointer.
+  bool UseTemp =
+      Dest.isPotentiallyAliased() || Dest.requiresGCollection() ||
+      (RequiresDestruction && Dest.isIgnored()) ||
+      (!Dest.isIgnored() && Dest.getAddress().getAddressSpace() !=
----------------
arsenm wrote:

What about the ignored case?

https://github.com/llvm/llvm-project/pull/183639