[clang] [clang] Replace `finish()` with destructors for `DiagnosticConsumer` (PR #183831)

Mon Mar 2 13:49:14 PST 2026

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-x86_64-windows` running on `minipc-ryzen-win` while building `clang` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/166/builds/6933

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-unified-tree) failure: build (failure)
...
6.802 [1/4/128] Building C object CMakeFiles\clang_rt.builtins-x86_64.dir\trunctfbf2.c.obj
6.812 [1/3/129] Building C object CMakeFiles\clang_rt.builtins-x86_64.dir\emutls.c.obj
6.886 [1/2/130] Building C object CMakeFiles\clang_rt.builtins-x86_64.dir\truncsfbf2.c.obj
7.251 [1/1/131] Building C object CMakeFiles\clang_rt.builtins-x86_64.dir\cpu_model\x86.c.obj
7.351 [0/1/132] Linking C static library C:\buildbot\flang-x86_64-windows\build\lib\clang\23\lib\windows\clang_rt.builtins-x86_64.lib
2253.515 [1684/6/5845] Linking CXX executable bin\llvm-profdata.exe
2254.999 [1682/6/5846] No install step for 'builtins'
2255.925 [1681/6/5848] Linking CXX executable bin\llvm-cov.exe
2256.259 [1680/6/5849] Linking CXX executable bin\llvm-gpu-loader.exe
2256.407 [1679/6/5850] Building CXX object tools\flang\tools\flang-driver\CMakeFiles\flang.dir\driver.cpp.obj
FAILED: [code=2] tools/flang/tools/flang-driver/CMakeFiles/flang.dir/driver.cpp.obj 
ccache C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\x64\cl.exe  /nologo /TP -DCLANG_BUILD_STATIC -DFLANG_INCLUDE_TESTS=1 -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\flang-x86_64-windows\build\tools\flang\tools\flang-driver -IC:\buildbot\flang-x86_64-windows\llvm-project\flang\tools\flang-driver -IC:\buildbot\flang-x86_64-windows\llvm-project\flang\include -IC:\buildbot\flang-x86_64-windows\build\tools\flang\include -IC:\buildbot\flang-x86_64-windows\build\include -IC:\buildbot\flang-x86_64-windows\llvm-project\llvm\include -external:IC:\buildbot\flang-x86_64-windows\llvm-project\flang\..\mlir\include -external:IC:\buildbot\flang-x86_64-windows\build\tools\mlir\include -external:IC:\buildbot\flang-x86_64-windows\build\tools\clang\include -external:IC:\buildbot\flang-x86_64-windows\llvm-project\llvm\..\clang\include -external:W0 /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4146 -wd4244 -wd4267 -wd4456 -wd4457 -wd4458 -wd4459 -wd4624 -wd4100 -wd4127 -wd4505 -wd4702 -wd4245 -wd4310 -wd4701 -wd4703 -wd4389 -wd4805 -wd4577 -wd4319 -wd4324 -wd4251 -wd4275 -w14062 -we4238 /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\flang\tools\flang-driver\CMakeFiles\flang.dir\driver.cpp.obj /Fdtools\flang\tools\flang-driver\CMakeFiles\flang.dir\ /FS -c C:\buildbot\flang-x86_64-windows\llvm-project\flang\tools\flang-driver\driver.cpp
..\llvm-project\flang\tools\flang-driver\driver.cpp(224): error C2039: 'finish': is not a member of 'clang::DiagnosticConsumer'
..\llvm-project\clang\include\clang/Basic/Diagnostic.h(1748): note: see declaration of 'clang::DiagnosticConsumer'
2257.629 [1679/5/5851] Linking CXX executable bin\llvm-jitlink.exe
2257.667 [1679/4/5852] Linking CXX executable bin\lli.exe
2309.237 [1679/3/5853] Building CXX object tools\flang\tools\flang-driver\CMakeFiles\flang.dir\fc1_main.cpp.obj
2313.406 [1679/2/5854] Building CXX object tools\flang\lib\Frontend\CMakeFiles\flangFrontend.dir\CompilerInvocation.cpp.obj
2314.022 [1679/1/5855] Building CXX object tools\flang\lib\Frontend\CMakeFiles\flangFrontend.dir\CompilerInstance.cpp.obj
ninja: build stopped: subcommand failed.
Cache directory:      C:\Users\buildbot-worker\AppData\Local\ccache
Config file:          C:\Users\buildbot-worker\AppData\Local\ccache\ccache.conf
System config file:   C:\ProgramData\ccache\ccache.conf
Stats updated:        03/02/26 13:49:03
Cacheable calls:       3966 / 3967 (99.97%)
  Hits:                3346 / 3966 (84.37%)
    Direct:            3329 / 3346 (99.49%)
    Preprocessed:        17 / 3346 ( 0.51%)
  Misses:               620 / 3966 (15.63%)
Uncacheable calls:        1 / 3967 ( 0.03%)
  Compilation failed:     1 /    1 (100.0%)
Successful lookups:
  Direct:              3329 / 3967 (83.92%)
  Preprocessed:          17 /  638 ( 2.66%)
Local storage:
  Cache size (GB):      5.0 /  5.0 (99.83%)
  Files:              23513
  Cleanups:              39
  Hits:                3346 / 3966 (84.37%)
  Misses:               620 / 3966 (15.63%)
  Reads:               7960
  Writes:              1231

```

</details>

https://github.com/llvm/llvm-project/pull/183831