[clang] [llvm] [SROA] Canonicalize homogeneous structs into fixed vectors (PR #165159)

[Yaxun Liu via cfe-commits]

yxsamliu wrote:

> > removed the TypePartitionTy == AI.getAllocatedType() check
> 
> The request nikic was making, on my behalf, was to pull this entirely outside of the `AI.getAllocatedType()` branch of the function, since I'm moving towards being able to delete that branch, as he mentioned. That said, I don't think that change is actually necessary for this PR. As long as you're confident in your tests here representing a cross-section of what this optimization should be able to do, then I think it will provide good coverage to ensure any future changes preserve the intent here.

Thanks for clarifying. I'll keep it inside the getAllocatedType() branch for now since tryCanonicalizeStructToVector depends on the TypePartitionTy from getTypePartition, which is only available there. Hopefully this won't create too much extra work when that branch gets removed — the lit tests should cover the expected behavior so it's clear what needs to be preserved. Let me know if any follow-up work is needed on my end.


https://github.com/llvm/llvm-project/pull/165159