[clang] [APINotes] Refactor APINotesReader to propagate llvm::Error (PR #183812)

[Gábor Horváth via cfe-commits]

================
@@ -1544,45 +1522,43 @@ bool APINotesReader::Implementation::readGlobalVariableBlock(
     }
 
     MaybeNext = Cursor.advance();
-    if (!MaybeNext) {
-      // FIXME this drops the error on the floor.
-      consumeError(MaybeNext.takeError());
-      return false;
-    }
+    if (!MaybeNext)
+      return MaybeNext.takeError();
+    ;
----------------
Xazax-hun wrote:

Stray semicolon. 

https://github.com/llvm/llvm-project/pull/183812