[clang] [Clang] Fix Itanium mangling crash for local lambda in ctor/dtor (PR #181068)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 2 02:32:17 PST 2026
https://github.com/eiytoq updated https://github.com/llvm/llvm-project/pull/181068
>From b59d5396bc8d6d470971734a8fd8bb70d6fafa4c Mon Sep 17 00:00:00 2001
From: eiytoq <eiytoq at outlook.com>
Date: Thu, 12 Feb 2026 09:25:21 +0800
Subject: [PATCH] [Clang] Fix Itanium mangling crash for local lambda in
ctor/dtor
---
clang/docs/ReleaseNotes.rst | 1 +
clang/lib/AST/ItaniumMangle.cpp | 16 +++++++++--
.../CodeGenCXX/dtor-local-lambda-mangle.cpp | 28 +++++++++++++++++++
3 files changed, 42 insertions(+), 3 deletions(-)
create mode 100644 clang/test/CodeGenCXX/dtor-local-lambda-mangle.cpp
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 668097236fe97..0a58ee6c7edab 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -327,6 +327,7 @@ Bug Fixes to C++ Support
when used inside decltype in the return type. (#GH180460)
- Fixed a crash when evaluating uninitialized GCC vector/ext_vector_type vectors in ``constexpr``. (#GH180044)
- Fixed a crash on ``typeid`` of incomplete local types during template instantiation. (#GH63242), (#GH176397)
+- Fixed a crash in Itanium C++ name mangling for a lambda in a local class field initializer inside a constructor/destructor. (#GH176395)
Bug Fixes to AST Handling
^^^^^^^^^^^^^^^^^^^^^^^^^
diff --git a/clang/lib/AST/ItaniumMangle.cpp b/clang/lib/AST/ItaniumMangle.cpp
index 1faf7f1466e39..48cd250d04047 100644
--- a/clang/lib/AST/ItaniumMangle.cpp
+++ b/clang/lib/AST/ItaniumMangle.cpp
@@ -2221,18 +2221,28 @@ void CXXNameMangler::manglePrefix(const DeclContext *DC, bool NoFunction) {
if (mangleSubstitution(ND))
return;
+ auto getPrefixGlobalDecl = [](const NamedDecl *ND) -> GlobalDecl {
+ if (const auto *CD = dyn_cast<CXXConstructorDecl>(ND))
+ return GlobalDecl(CD, Ctor_Complete);
+ if (const auto *DD = dyn_cast<CXXDestructorDecl>(ND))
+ return GlobalDecl(DD, Dtor_Complete);
+ if (const auto *FD = dyn_cast<FunctionDecl>(ND))
+ return GlobalDecl(FD);
+ return GlobalDecl(ND);
+ };
+
// Check if we have a template-prefix or a closure-prefix.
const TemplateArgumentList *TemplateArgs = nullptr;
- if (GlobalDecl TD = isTemplate(ND, TemplateArgs)) {
+ if (GlobalDecl TD = isTemplate(getPrefixGlobalDecl(ND), TemplateArgs)) {
mangleTemplatePrefix(TD);
mangleTemplateArgs(asTemplateName(TD), *TemplateArgs);
} else if (const NamedDecl *PrefixND = getClosurePrefix(ND)) {
mangleClosurePrefix(PrefixND, NoFunction);
- mangleUnqualifiedName(ND, nullptr, nullptr);
+ mangleUnqualifiedName(getPrefixGlobalDecl(ND), nullptr, nullptr);
} else {
const DeclContext *DC = Context.getEffectiveDeclContext(ND);
manglePrefix(DC, NoFunction);
- mangleUnqualifiedName(ND, DC, nullptr);
+ mangleUnqualifiedName(getPrefixGlobalDecl(ND), DC, nullptr);
}
addSubstitution(ND);
diff --git a/clang/test/CodeGenCXX/dtor-local-lambda-mangle.cpp b/clang/test/CodeGenCXX/dtor-local-lambda-mangle.cpp
new file mode 100644
index 0000000000000..49d3621ca00cf
--- /dev/null
+++ b/clang/test/CodeGenCXX/dtor-local-lambda-mangle.cpp
@@ -0,0 +1,28 @@
+// RUN: %clang_cc1 -triple %itanium_abi_triple -std=c++20 -O2 -emit-llvm -o /dev/null %s
+// RUN: %clang_cc1 -triple %itanium_abi_triple -std=c++20 -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple %itanium_abi_triple -std=c++20 -fclang-abi-compat=18 -emit-llvm -o - %s | FileCheck %s
+
+struct E {
+ E();
+ ~E();
+};
+
+E::E() {
+ struct {
+ int anotherValue = [] { return 1; }();
+ } obj;
+}
+
+E::~E() {
+ struct {
+ int anotherValue = [] { return 2; }();
+ } obj;
+}
+
+// CHECK-LABEL: define{{.*}} @"_ZZN1EC1EvEN3$_0C2Ev"
+// CHECK: call{{.*}} @"_ZZN1EC1EvENK3$_012anotherValueMUlvE_clEv"
+// CHECK-LABEL: define{{.*}} @"_ZZN1EC1EvENK3$_012anotherValueMUlvE_clEv"
+
+// CHECK-LABEL: define{{.*}} @"_ZZN1ED1EvEN3$_0C2Ev"
+// CHECK: call{{.*}} @"_ZZN1ED1EvENK3$_012anotherValueMUlvE_clEv"
+// CHECK-LABEL: define{{.*}} @"_ZZN1ED1EvENK3$_012anotherValueMUlvE_clEv"
More information about the cfe-commits
mailing list