[clang] [Clang][NFCI] Enforce immutability of global strings (PR #183287)

[Eli Friedman via cfe-commits]

================
@@ -288,7 +288,7 @@ llvm::Error DirectoryScanner::scanForFrameworks(StringRef Directory) {
   }
 
   // Check known sub-directory locations.
-  for (const auto *SubDir : SubDirectories) {
+  for (const auto *const SubDir : SubDirectories) {
----------------
efriedma-quic wrote:

I don't think "const" here helps readability.

https://github.com/llvm/llvm-project/pull/183287