[clang] [clang][NFC] ItaniumMangle: polish comments (PR #183030)
via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 24 03:48:53 PST 2026
https://github.com/eiytoq updated https://github.com/llvm/llvm-project/pull/183030
>From acf4caef6e1fd57ac5ddf0072ad07a0adde4cf5e Mon Sep 17 00:00:00 2001
From: eiytoq <eiytoq at outlook.com>
Date: Tue, 24 Feb 2026 19:36:28 +0800
Subject: [PATCH 1/2] [clang][NFC] ItaniumMangle: polish comments
---
clang/lib/AST/ItaniumMangle.cpp | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/clang/lib/AST/ItaniumMangle.cpp b/clang/lib/AST/ItaniumMangle.cpp
index df00760fa911b..08aa9dbb19682 100644
--- a/clang/lib/AST/ItaniumMangle.cpp
+++ b/clang/lib/AST/ItaniumMangle.cpp
@@ -802,8 +802,8 @@ void CXXNameMangler::mangleSourceNameWithAbiTags(
void CXXNameMangler::mangle(GlobalDecl GD) {
// <mangled-name> ::= _Z <encoding>
- // ::= <data name>
- // ::= <special-name>
+ // ::= <data name>
+ // ::= <special-name>
Out << "_Z";
if (isa<FunctionDecl>(GD.getDecl()))
mangleFunctionEncoding(GD);
@@ -7248,16 +7248,8 @@ bool CXXNameMangler::shouldHaveAbiTags(ItaniumMangleContextImpl &C,
return TrackAbiTags.AbiTagsRoot.getUsedAbiTags().size();
}
-//
-
-/// Mangles the name of the declaration D and emits that name to the given
-/// output stream.
-///
-/// If the declaration D requires a mangled name, this routine will emit that
-/// mangled name to \p os and return true. Otherwise, \p os will be unchanged
-/// and this routine will return false. In this case, the caller should just
-/// emit the identifier of the declaration (\c D->getIdentifier()) as its
-/// name.
+/// Mangles the name of the declaration \p GD and emits that name to the given
+/// output stream \p Out.
void ItaniumMangleContextImpl::mangleCXXName(GlobalDecl GD,
raw_ostream &Out) {
const NamedDecl *D = cast<NamedDecl>(GD.getDecl());
>From e049ef84afafebb679deea2ddcb194df4fbe1530 Mon Sep 17 00:00:00 2001
From: eiytoq <eiytoq at outlook.com>
Date: Tue, 24 Feb 2026 19:46:06 +0800
Subject: [PATCH 2/2] nfc
---
clang/lib/AST/ItaniumMangle.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/clang/lib/AST/ItaniumMangle.cpp b/clang/lib/AST/ItaniumMangle.cpp
index 08aa9dbb19682..f1d78110656dc 100644
--- a/clang/lib/AST/ItaniumMangle.cpp
+++ b/clang/lib/AST/ItaniumMangle.cpp
@@ -1104,10 +1104,10 @@ void CXXNameMangler::mangleModuleName(const NamedDecl *ND) {
}
// <module-name> ::= <module-subname>
-// ::= <module-name> <module-subname>
-// ::= <substitution>
+// ::= <module-name> <module-subname>
+// ::= <substitution>
// <module-subname> ::= W <source-name>
-// ::= W P <source-name>
+// ::= W P <source-name>
void CXXNameMangler::mangleModuleNamePrefix(StringRef Name, bool IsPartition) {
// <substitution> ::= S <seq-id> _
auto It = ModuleSubstitutions.find(Name);
More information about the cfe-commits
mailing list