[clang] [Clang][CodeGen][CUDA] Add missing null-check assertions in CGCUDARuntime (PR #181167)
Oliver Hunt via cfe-commits
cfe-commits at lists.llvm.org
Sun Feb 22 18:36:26 PST 2026
https://github.com/ojhunt requested changes to this pull request.
No.
The LLVM project requires:
(1) You state whether you used an LLM to produce a PR
(2) You indicate what parts of the PR were produced
(3) You have reviewed and confirmed that the LLM produced code is correct
This PR does not do 1 or 2, and you did not do 3.
The report says it adds null check assertions.
It does not.
It makes incorrect changes from getAs<> to cast<> which frequently (if not always) has different semantics. Even if cast<> was the correct semantic change for getting a null check the correct change would have been to castAs<>.
GH only gives me the option to respond with "Request Changes", but it should be closed as incorrect by design.
https://github.com/llvm/llvm-project/pull/181167
More information about the cfe-commits
mailing list