[clang] Diagnose potential size confusion with VLA params [contd.] (PR #181550)

[Yeoul Na via cfe-commits]

================
@@ -1114,7 +1114,8 @@ def VexingParse : DiagGroup<"vexing-parse">;
 def VLAUseStaticAssert : DiagGroup<"vla-extension-static-assert">;
 def VLACxxExtension : DiagGroup<"vla-cxx-extension", [VLAUseStaticAssert]>;
 def VLAExtension : DiagGroup<"vla-extension", [VLACxxExtension]>;
-def VLA : DiagGroup<"vla", [VLAExtension]>;
+def VLASizeConfusion : DiagGroup<"vla-potential-size-confusion">;
----------------
rapidsna wrote:

Ah yes, you're right. It changes the meaning of name 'n' itself within the scope, and that's actually the same situation.

https://github.com/llvm/llvm-project/pull/181550